Fix possible integer overflow in the standard worker loop in the docs - #2599
Closed
gggeek wants to merge 1 commit into
Closed
Fix possible integer overflow in the standard worker loop in the docs#2599gggeek wants to merge 1 commit into
gggeek wants to merge 1 commit into
Conversation
Contributor
In PHP integers don't underflow but instead get promoted to floats. At some point the next available double is going to be further than 1 step away and $var++ does nothing. |
Author
One never stops learning 馃槉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
$_SERVER['MAX_REQUESTS']is unset or 0, the for loop as originally shown would overflow the$nbRequestsvariable in the end.Not that I did experience that, but I think that it would have resulted in an error page at some point (for a very, very busy server).
The code changes this to exit the worker cleanly instead.
I think this is better, even though it is just slightly less readable.